cmd: ethsw: Fix out-of-bounds error

The for loop in cmd_keywords_opt_check() seems to use wrong array to
set boundary, reported by Coverity analysis.

Signed-off-by: York Sun <[email protected]>
CC: Joe Hershberger <[email protected]>
CC: Tom Rini <[email protected]>
CC: Prabhakar Kushwaha <[email protected]>
Reported-by: Coverity (CID: 163251)
Reviewed-by: Tom Rini <[email protected]>
Acked-by: Joe Hershberger <[email protected]>

diff --git a/cmd/ethsw.c b/cmd/ethsw.c
index 491cb8eac385ed8ecf44ab6a2f46ab6bf57a59f9..b600965e8ad43a4764b519e5b89b8be1714dd17b 100644 (file)
--- a/cmd/ethsw.c
+++ b/cmd/ethsw.c
@@ -915,7 +915,7 @@ static void cmd_keywords_opt_check(const struct ethsw_command_def *parsed_cmd,
         * check if our command's optional keywords match the optional
         * keywords of an available command
         */
-       for (i = 0; i < ARRAY_SIZE(ethsw_cmd_def); i++) {
+       for (i = 0; i < ARRAY_SIZE(cmd_opt_def); i++) {
                keyw_opt_matched = 0;
                cmd_keyw_p = &parsed_cmd->cmd_to_keywords[keyw_opt_matched];
                cmd_keyw_opt_p = &cmd_opt_def[i].cmd_keyword[keyw_opt_matched];